Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Cleanup code #510

Merged
merged 6 commits into from
Sep 5, 2024
Merged

Conversation

Lamparter
Copy link
Collaborator

🧪 Built and tested using Visual Studio Batch Build!

(built and tested using Visual Studio Batch Build)
Unfortunately some organised import statements were lost, see comment for more info.
@Lamparter Lamparter requested a review from 0x5bfa as a code owner September 4, 2024 20:27
@Lamparter Lamparter self-assigned this Sep 4, 2024
@Lamparter Lamparter added this to the FluentHub v1.0.0 milestone Sep 4, 2024
@Lamparter
Copy link
Collaborator Author

@0x5bfa I'll wait for your review :octocat:

@Lamparter Lamparter requested review from 0x5bfa and removed request for 0x5bfa September 5, 2024 06:46
Copy link
Owner

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM.

  • Removing unnecessary using directives
  • Formatting C# code

src/FluentHub.App/GlobalUsings.cs Outdated Show resolved Hide resolved
@0x5bfa 0x5bfa self-requested a review September 5, 2024 06:54
0x5bfa
0x5bfa previously requested changes Sep 5, 2024
Copy link
Owner

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As described above.

@Lamparter Lamparter merged commit cbb1b52 into lamparter/refactor Sep 5, 2024
5 checks passed
@Lamparter Lamparter deleted the lamparter/cleanup branch September 5, 2024 07:25
@Lamparter Lamparter mentioned this pull request Sep 15, 2024
66 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants