Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add edit with VS Code button #504

Merged
merged 50 commits into from
Dec 25, 2024
Merged

Conversation

Lamparter
Copy link
Collaborator

@Lamparter Lamparter commented Aug 29, 2024

📄 Description

Add edit with VS Code button (and various other GitCloneFlyout changes

💭 Motivation and context

(Partially) fixes #188 and #495


sequenceDiagram
    participant User
    participant GitCloneFlyout
    participant ExternalApp
    participant Browser
    User->>GitCloneFlyout: Click clone button
    GitCloneFlyout->>ExternalApp: Attempt to open repository
    alt ExternalApp installed
        ExternalApp-->>GitCloneFlyout: Success
        GitCloneFlyout->>GitCloneFlyout: Log success
    else ExternalApp not installed
        ExternalApp-->>GitCloneFlyout: Failure
        GitCloneFlyout->>GitCloneFlyout: Log error
        GitCloneFlyout->>Browser: Open download page
        Browser-->>GitCloneFlyout: Success/Failure
        GitCloneFlyout->>GitCloneFlyout: Log result
    end
Loading

@Lamparter Lamparter requested a review from 0x5bfa as a code owner August 29, 2024 10:29
@Lamparter
Copy link
Collaborator Author

I think we should reduce the size of the button as well since there's lots of options
image
Need to add Code Insiders support as well.

@Lamparter

This comment was marked as outdated.

@Lamparter
Copy link
Collaborator Author

Should navigate to VS(Code) download page when those events fail too

This commit was automated by GitKraken
@Lamparter

This comment was marked as outdated.

@Lamparter
Copy link
Collaborator Author

UWP Community > #dev-help This is probably a stupid error...

@0x5bfa
Copy link
Owner

0x5bfa commented Sep 27, 2024

@sourcery-ai review

This comment was marked as spam.

sourcery-ai[bot]

This comment was marked as spam.

@Lamparter
Copy link
Collaborator Author

This PR is finished. @0x5bfa requesting your review.

@0x5bfa 0x5bfa merged commit e7be5a2 into lamparter/refactor Dec 25, 2024
5 checks passed
@0x5bfa 0x5bfa deleted the lamparter/vscode branch December 25, 2024 14:42
@0x5bfa
Copy link
Owner

0x5bfa commented Dec 25, 2024

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
2 participants