Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub: Improve issue & PR templates #487

Merged
merged 9 commits into from
Jul 21, 2024
Merged

GitHub: Improve issue & PR templates #487

merged 9 commits into from
Jul 21, 2024

Conversation

Lamparter
Copy link
Collaborator

No description provided.

@Lamparter Lamparter requested a review from 0x5bfa as a code owner July 21, 2024 09:24
@Lamparter Lamparter self-assigned this Jul 21, 2024
@Lamparter Lamparter added type/code-quality triage/approved This PR has been approved by the team. labels Jul 21, 2024
0x5bfa
0x5bfa requested changes Jul 21, 2024
View reviewed changes
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/feature_request.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/feature_request.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/spec.yml Outdated Show resolved Hide resolved
0x5bfa
0x5bfa reviewed Jul 21, 2024
View reviewed changes
Copy link
Owner

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than below, looks great 👍

.github/ISSUE_TEMPLATE/bug_report.yml Show resolved Hide resolved
.github/ISSUE_TEMPLATE/config.yml Show resolved Hide resolved
.github/ISSUE_TEMPLATE/feature_request.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/feature_request.yml Outdated Show resolved Hide resolved
@Lamparter Lamparter requested a review from 0x5bfa July 21, 2024 09:55
0x5bfa
0x5bfa approved these changes Jul 21, 2024
View reviewed changes
Copy link
Owner

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could delete spec.yml but for now it's good.

@0x5bfa 0x5bfa changed the title Add new issue templates GitHub: Improve issue & PR templates Jul 21, 2024
@0x5bfa 0x5bfa enabled auto-merge (squash) July 21, 2024 09:59
@0x5bfa
Copy link
Owner

0x5bfa commented Jul 21, 2024

Thank you! This PR will be merged after all CI succeeded.

@Lamparter
Copy link
Collaborator Author

Lamparter commented Jul 21, 2024 •
edited
Loading

Amazing! ❤️

@Lamparter
Copy link
Collaborator Author

Lamparter commented Jul 21, 2024 •
edited
Loading

image

@0x5bfa 0x5bfa merged commit 834ad10 into main Jul 21, 2024
6 checks passed
@0x5bfa 0x5bfa deleted the lamparter/issues branch July 21, 2024 10:02
@0x5bfa
Copy link
Owner

0x5bfa commented Jul 21, 2024

Modified branch protection rule, now merged.

@Lamparter Lamparter mentioned this pull request Jul 21, 2024
Open
66 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x5bfa 0x5bfa 0x5bfa approved these changes

Assignees

@Lamparter Lamparter

Labels
triage/approved This PR has been approved by the team. type/code-quality
Projects
FluentHub Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lamparter @0x5bfa