-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Adding_Filters #510
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Thank you for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that the UI and functionality may look fine, but it is not working as it is.
Do see the comments added and make the required changes. Also as you are creating a new file which is not needed, add the filter component in index.html page and make it work for the currently added cars.
@@ -0,0 +1,171 @@ | |||
###html### |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
filename do not have the extension
@@ -0,0 +1,171 @@ | |||
###html### |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
</body> | ||
</html> | ||
|
||
###css## |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Create a new css file and import this code to that file and import here
border-radius: 4px; | ||
} | ||
|
||
##js## |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
create a new js file to make this filter code reusable and import it to the page which would need the filtering component
🚀 Pull Request
Description
Please include a summary of the changes and the related issue. Provide relevant motivation and context. List any dependencies that are required for this change.
By implementing detailed filters such as vehicle type, price range, location, rental duration, and user ratings, the application enables users to efficiently sift through a wide array of vehicle options. This level of granularity in filtering ensures that users find the exact vehicle that meets their needs while enhancing their overall experience. With these filters in place, users can save time and make more informed decisions.
Fixes # (issue)
#269
Type of Change
Checklist:
Screenshot of final output/video