Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Adding_Filters #510

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

23wh1a0513
Copy link

🚀 Pull Request

Description

Please include a summary of the changes and the related issue. Provide relevant motivation and context. List any dependencies that are required for this change.
By implementing detailed filters such as vehicle type, price range, location, rental duration, and user ratings, the application enables users to efficiently sift through a wide array of vehicle options. This level of granularity in filtering ensures that users find the exact vehicle that meets their needs while enhancing their overall experience. With these filters in place, users can save time and make more informed decisions.

Fixes # (issue)
#269

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshot of final output/video

WhatsApp Image 2024-10-22 at 9 43 02 PM

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better

Copy link
Collaborator

@akbatra567 akbatra567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that the UI and functionality may look fine, but it is not working as it is.
Do see the comments added and make the required changes. Also as you are creating a new file which is not needed, add the filter component in index.html page and make it work for the currently added cars.

@@ -0,0 +1,171 @@
###html###
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

filename do not have the extension

@@ -0,0 +1,171 @@
###html###
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When changed to .html file the page looks like this:

Uploading Screenshot 2024-10-23 at 12.08.28 AM.png…

</body>
</html>

###css##
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create a new css file and import this code to that file and import here

border-radius: 4px;
}

##js##
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create a new js file to make this filter code reusable and import it to the page which would need the filtering component

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants