Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reference table, broken icons #13

Open
allefeld opened this issue Nov 28, 2019 · 1 comment
Open

reference table, broken icons #13

allefeld opened this issue Nov 28, 2019 · 1 comment

Comments

@allefeld
Copy link

allefeld commented Nov 28, 2019

I made a reference table as an HTML document to be more easily able to pick the right HTML entity references for a given icon. I've attached it here (octicons-webfont.html.gz) because I thought it might be a useful addition to the package documentation.

While viewing this in current Chrome (78.0.3904.108), I noticed that some icons are not correctly rendered.

image

As far as I can see, that applies to:
broadcast, circle-slash, clock, dashboard, dependent, eye-closed, file-pdf, file-zip, git-branch/merge/pull-request/action, history, kebab-horizontal/vertical, mark-github, person, primitive-dot-stroke, question, radio-tower, repo-forked, report, request-changes, rss, search, skip, sync, unmute, unverified, verified, workflow-all.

The same holds in Firefox 68.2.0esr and Atom 1.41.0.

Given that the original authors have abandoned webfont-support in primer/octicons, I think your repository can be extremely useful, but only if these errors are fixed.

@allefeld allefeld changed the title reference table, broken icons in Chrome reference table, broken icons Nov 28, 2019
@zypA13510
Copy link
Owner

zypA13510 commented Nov 29, 2019

Yes, I have also observed these issues with rendering. I guess they have something to do with the unmaintained grunt-webfont and its outdated dependencies, or the parameters here. It could take some time to investigate. If you have any interesting discovery please let me know.

Edit: List of broken icons as of v1.5.0: (out of 204 total, 43 broken, 3 with minor issue)

  • archive
  • beaker
  • broadcast
  • circle-slash
  • clock
  • dashboard
  • dependent
  • eye-closed
  • file-pdf
  • file-zip
  • git-branch
  • git-compare
  • git-merge
  • git-pull-request
  • github-action
  • heart-outline
  • history
  • infinity
  • internal-repo
  • issue-closed
  • issue-opened
  • issue-reopened
  • kebab-horizontal
  • kebab-vertical
  • mark-github
  • pencil*
  • person
  • play
  • primitive-dot-stroke
  • project
  • question
  • radio-tower
  • repo-forked
  • report*
  • request-changes*
  • rocket
  • rss
  • search
  • skip
  • smiley
  • sync
  • unmute
  • unverified
  • verified
  • workflow-all
  • workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants