Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial global filter display is incorrect for add, sub and pad #388

Open
pgervais opened this issue Apr 17, 2023 · 5 comments
Open

Initial global filter display is incorrect for add, sub and pad #388

pgervais opened this issue Apr 17, 2023 · 5 comments

Comments

@pgervais
Copy link
Collaborator

Step to reproduce the issue:

Launch

  • Launch zest
  • Go to Add > Global > Filter

The filter display does not match the filter type shown in the 'general' card:
Incorrect view

  • Switch the filter type using the dropdown: the filter display stays the same. Expected: it updates to the correct type.

The display updates when a click happens in a non-widget part of the 'general' card. For example at the location of the cross in the above screenshot. The view then becomes correct, and switching the filter type correctly works. This is the correct view:

Correct view

The same behavior happens with the "sub" and pad > envelopes tabs.

@pgervais pgervais added the bug label Apr 17, 2023
@fundamental
Copy link
Member

I cannot replicate the issue as described.

@pgervais
Copy link
Collaborator Author

After tinkering with the UI a bit more I realized that it's working as intended. What I missed is that what the graphical display shows depends on which panel (general / envelope / lfo) is active. Unfortunately there is no visual indication of that.

One option would be to have the panel's header highlighted, the same way "filter" or "global" are shown.

@fundamental
Copy link
Member

Having a visual hint there would be good IMO, though likely it should be more subtle than the filter/global highlighting to avoid distracting the user with an element in the center of the screen.

@polluxsynth
Copy link

Perhaps just show a legend in the upper left hand corner of the display, like "ENVELOPE", "RESPONSE", "LFO" etc?

@fundamental
Copy link
Member

That's a possible solution, though adding the a slight highlight to the titlebars would create an added bonus of hinting that they're clickable which I've heard in the past is a UX issue with the current implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants