Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Project Classify Header #534

Open
seanmiller26 opened this issue Mar 6, 2024 · 3 comments
Open

Add Project Classify Header #534

seanmiller26 opened this issue Mar 6, 2024 · 3 comments
Labels

Comments

@seanmiller26
Copy link

The reskinned classifier uses this header as part of the design. This will help signal to users that they are on a specific project's classify page.

The images are pulled from the project's uploaded Background Image.

I have included 3 examples to help show the gradient overlay. #979797 (Also the new classifier background color)
Screen Shot 2024-03-06 at 1 50 37 PMScreen Shot 2024-03-06 at 1 50 53 PMScreen Shot 2024-03-06 at 1 51 54 PM

The idea is that the classifier will overlap the header.
Screen Shot 2024-03-06 at 1 59 35 PM
I tried to illustrate that here:
Screen Shot 2024-03-06 at 1 59 53 PM

All details can be found in the Figma file here, including tablet specifications.

@lcjohnso
Copy link
Member

lcjohnso commented Mar 8, 2024

@seanmiller26

  1. What is the fallback in the case of no background image?
  2. While you show that a variety of background images are compatible, how confident are you that all project background images are suitable for this use? I'm relatively convinced & confident that this should work, but at the very least we should be sure to perform a comprehensive check of all current mobile projects during review.

@seanmiller26
Copy link
Author

Great questions

What is the fallback in the case of no background image?

Brand color #005D69 with all the same same overlays.

Screen Shot 2024-03-08 at 12 04 37 PM

...how confident are you that all project background images are suitable for this use?

I just audited the first 20 projects shown on the app and they look great. Happy to do more if we want to be comprehensive, but even the improper image sizes look nice (see Eyes on Eyes; portrait ratio image). Here are some more examples:

Screen Shot 2024-03-08 at 12 01 52 PM Screen Shot 2024-03-08 at 11 55 08 AM Screen Shot 2024-03-08 at 11 53 50 AM Screen Shot 2024-03-08 at 11 56 07 AM Screen Shot 2024-03-08 at 11 52 43 AM Screen Shot 2024-03-08 at 11 48 33 AM Screen Shot 2024-03-08 at 11 45 31 AM Screen Shot 2024-03-08 at 11 43 47 AM Screen Shot 2024-03-08 at 11 42 54 AM

@lcjohnso
Copy link
Member

lcjohnso commented Mar 8, 2024

Looks great! I have no concerns moving forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants