From 011c2d00f2ee71222c6604a24eee0113bb303d70 Mon Sep 17 00:00:00 2001 From: Alex Giurgiu Date: Tue, 17 Dec 2024 18:09:11 +0200 Subject: [PATCH 1/2] fixed secret name for cert volume Signed-off-by: Alex Giurgiu --- charts/milvus-operator/templates/deployment.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/charts/milvus-operator/templates/deployment.yaml b/charts/milvus-operator/templates/deployment.yaml index d4610e51..d5421329 100644 --- a/charts/milvus-operator/templates/deployment.yaml +++ b/charts/milvus-operator/templates/deployment.yaml @@ -68,5 +68,5 @@ spec: - name: cert secret: defaultMode: 420 - # secretName: {{ include "$.chart.fullname" . }}-webhook-cert + secretName: {{ include "chart.fullname" . }}-webhook-cert {{- end }} From 4010b8344775d3f2a67d1f3b04a2db19a0e3e327 Mon Sep 17 00:00:00 2001 From: Alex Giurgiu Date: Thu, 19 Dec 2024 18:11:26 +0200 Subject: [PATCH 2/2] when enableWebhook is set to true, explicitly add the webhook argument, because by default its set to false --- charts/milvus-operator/templates/deployment.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/charts/milvus-operator/templates/deployment.yaml b/charts/milvus-operator/templates/deployment.yaml index d5421329..84945924 100644 --- a/charts/milvus-operator/templates/deployment.yaml +++ b/charts/milvus-operator/templates/deployment.yaml @@ -22,8 +22,8 @@ spec: - --health-probe-bind-address=:8081 - --metrics-bind-address=:8080 - --leader-elect - {{- if not .Values.enableWebhook }} - - --webhook=false + {{- if .Values.enableWebhook }} + - --webhook=true {{- end }} command: - /manager