Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting nodeSelectors and tolerations for pulsar components #124

Open
aliabbasjaffri opened this issue Sep 6, 2024 · 9 comments
Open
Labels
enhancement New feature or request

Comments

@aliabbasjaffri
Copy link

For nodes with custom labels and taints, there is currently no way to natively set nodeSelectors and tolerations on all the pods created by pulsar in a kubernetes cluster

@haorenfsa haorenfsa added the enhancement New feature or request label Sep 11, 2024
@aliabbasjaffri
Copy link
Author

This can be done by bumping up pulsar version. The current set version is 2.7.8 which does not support tolerations in the helm chart, however version 3.5.0 supports tolerations.

@aliabbasjaffri
Copy link
Author

aliabbasjaffri commented Sep 15, 2024

However i'm not sure what would be the side-effects of bumping the version.

However, pulsar version 2.7.8 was updated 3 years ago, any reason why it has not been updated?

@haorenfsa
Copy link
Collaborator

pulsar v3 chart doesn't support pulsar v2 image. So we're still using v2 for backward compatibility.
milvus-io/milvus#30812

As a walk around, You can deploy pulsar with v3 chart and then configure milvus to use that pulsar. Or you can also use milvus-operator.

@aliabbasjaffri
Copy link
Author

Is there any timeline to when pulsar v3 would be supported by the helm chart?

@haorenfsa
Copy link
Collaborator

haorenfsa commented Sep 19, 2024

@aliabbasjaffri It will probably be in October. We are still designing a solution to introduce it without affecting compatibility.

@colinbjohnson
Copy link

@aliabbasjaffri although we would love to utilize pulsar version 3 we are using the existing milvus helm charts with pulsar and nodeSelectors.

proxy:
  nodeSelector:
    kubernetes.io/arch: amd64
  replicaCount: 1
  podMonitor:
    enabled: false
  resources:
    requests:
      memory: 2048Mi
      cpu: 1
  service:
    type: ClusterIP
  ports:
    pulsar: 6650
  configData:
    PULSAR_MEM: >
      -Xms2048m -Xmx2048m
    PULSAR_GC: >
      -XX:MaxDirectMemorySize=2048m

@aliabbasjaffri
Copy link
Author

@colinbjohnson that is strange, how do you pass nodeSelector to pulsar_metadata component which then passes those values to bookkeeper-cluster-init and pulsar-cluster-init, given any of those are not supported by pulsar helm chart version 2.7.8.

@haorenfsa
Copy link
Collaborator

milvus-operator now supports pulsar-v3 chart, check this sample: https://github.com/zilliztech/milvus-operator/blob/main/config/samples/milvus_pulsar_v3.yaml

milvus-helm chart will support it later.

@haorenfsa
Copy link
Collaborator

related to: milvus-io/milvus#30812

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants