Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++ header assumes 64-bit pointers #2

Open
lhoward opened this issue Apr 12, 2021 · 1 comment
Open

C++ header assumes 64-bit pointers #2

lhoward opened this issue Apr 12, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@lhoward
Copy link

lhoward commented Apr 12, 2021

Should likely use uintptr_t rather than uint64_t.
@zhuowei
Copy link
Owner

zhuowei commented Apr 12, 2021

I went with uint64_t directly because:

  • I only test this on x86-64, so even if I switched to uintptr_t/usize I'd likely break something else on 32-bit and not notice
  • uint64_t is enough to hold a 32-bit pointer anyways at a slight cost in performance

@zhuowei zhuowei added the enhancement New feature or request label Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lhoward @zhuowei