We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RequestValidator -> validateHmac errors out when there is an array in the query params eg: &ids%5B%5D=1125508776045
The text was updated successfully, but these errors were encountered:
As per: https://community.shopify.com/c/Shopify-APIs-SDKs/HMAC-verification-issues/m-p/201515/highlight/true#M9442 Instead of $pairs[] = $key . '=' . $value; we should have if (is_array($value)) { $pairs[] = $key . '=["' . implode(", ", $value) . '"]'; } else { $value = strtr($value, ['&' => '%26', '%' => '%25']); $pairs[] = $key . '=' . $value; }
$pairs[] = $key . '=' . $value;
if (is_array($value)) { $pairs[] = $key . '=["' . implode(", ", $value) . '"]'; } else { $value = strtr($value, ['&' => '%26', '%' => '%25']); $pairs[] = $key . '=' . $value; }
Sorry, something went wrong.
Hi,
This is very interesting. Could you please submit a PR, including unit tests to validate the approach?
No branches or pull requests
RequestValidator -> validateHmac errors out when there is an array in the query params
eg: &ids%5B%5D=1125508776045
The text was updated successfully, but these errors were encountered: