Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: routinegroup & etcd watch goroutine leak #4514

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

update code for unit test

742237e
Select commit
Loading
Failed to load commit list.
Open

fix: routinegroup & etcd watch goroutine leak #4514

update code for unit test
742237e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Dec 28, 2024 in 1s

83.05% of diff hit (target 94.67%)

View this Pull Request on Codecov

83.05% of diff hit (target 94.67%)

Annotations

Check warning on line 66 in core/discov/internal/registry.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

core/discov/internal/registry.go#L65-L66

Added lines #L65 - L66 were not covered by tests

Check warning on line 285 in core/discov/internal/registry.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

core/discov/internal/registry.go#L282-L285

Added lines #L282 - L285 were not covered by tests

Check warning on line 333 in core/discov/internal/registry.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

core/discov/internal/registry.go#L333

Added line #L333 was not covered by tests

Check warning on line 33 in core/discov/subscriber.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

core/discov/subscriber.go#L33

Added line #L33 was not covered by tests

Check warning on line 41 in zrpc/resolver/internal/discovbuilder.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

zrpc/resolver/internal/discovbuilder.go#L41

Added line #L41 was not covered by tests