Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.5.6 reports it's version as v1.5.5 #3595

Closed
p-linnane opened this issue Sep 27, 2023 · 5 comments
Closed

v1.5.6 reports it's version as v1.5.5 #3595

p-linnane opened this issue Sep 27, 2023 · 5 comments

Comments

@p-linnane
Copy link

Hello 👋 . I'm a maintainer for the Homebrew project. While packaging v1.5.6 of goctl, we noticed the version is still being reported as v1.5.5. This is causing our tests to fail due to the version mismatch.

Relates to Homebrew/homebrew-core#146343

@kevwan
Copy link
Contributor

kevwan commented Sep 30, 2023

Thanks for your reporting!

Sorry for the inconvinience! I drafted the relase and then updated ther goctl version, I guess it's not updated when I release goctl.

I'm not sure how to fix the issue. Would you please give some advises?

We're in a national holiday, sorry for the delayed reply.

@p-linnane
Copy link
Author

The best thing to do would be to fix the version and make a new release.

@p-linnane
Copy link
Author

The issue is that this commit did not make it into the v1.5.6 tag: 4878f90.

The v1.5.6 tag is this commit: 421e661

@p-linnane
Copy link
Author

I see now that you cut releases specifically for goctl, separate from the main tag. Switching to use that specific release fixed our issue. Thank you!

@kevwan
Copy link
Contributor

kevwan commented Oct 1, 2023

I see now that you cut releases specifically for goctl, separate from the main tag. Switching to use that specific release fixed our issue. Thank you!

Awesome! Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants