hide_floating_panes doesn't work with a `default_tab_template` #2974

i-am-logger · 2023-12-01T11:35:32Z

Hi, here is the layout i'm loading, btop always shows even though hide_floating_panes=true

using zellij 0.38.1 on nixos

PS. is there a way to setup keybinding to show/hide the pane?

    tab name="Dev" focus=true hide_floating_panes=true {
        pane split_direction="vertical" {
            pane name="editor" borderless=true {
                edit "."
            }
        }
        pane split_direction="vertical" size=8 {
            pane name="cargo run" borderless=true {
                command "cargo" 
                args "run"
            } 
            pane size="20%" borderless=true
        }
        floating_panes {
            pane {
                x "10%"
                y "10%"
                width "80%"
                height "80%"
                command "btop"
            }
        }
    }

The text was updated successfully, but these errors were encountered:

imsnif · 2023-12-01T11:40:18Z

Works for me...

What I'm doing: I placed a layout node around it and loaded it with zellij -l /path/to/layout.kdl. The layout is loaded and btop is only triggered when I trigger the floating panes with Ctrl p + w. Also, this is the only way to trigger floating panes unless they're a plugin (and then you can focus the pane specifically with the LaunchOrFocus binding).

i-am-logger · 2023-12-01T11:42:06Z

this is my full layout

layout name="sky360" {
    default_tab_template {
        pane size=1 borderless=true {
            plugin location="zellij:tab-bar"
        }
        children
        // TODO: figure out how to show/hide a pane
        // pane size=2 borderless=true {
        //     plugin location="zellij:status-bar"
        // }
    }

    tab name="Sky360-Dev" focus=true hide_floating_panes=true {
        pane split_direction="vertical" {
            pane name="editor" borderless=true {
                edit "."
            }
        }
        pane split_direction="vertical" size=8 {
            pane name="cargo run" borderless=true {
                command "cargo" 
                args "run"
            } 
            pane size="20%" borderless=true
        }
        floating_panes {
            pane {
                x "10%"
                y "10%"
                width "80%"
                height "80%"
                command "btop"
            }
        }
    }
    tab name="terminal" {
        pane {
            borderless true
        }
    }
    // tab name="browser" {
    //     pane {
    //         command "w3m"
    //         args "https://search.nixos.org/packages"
    //         borderless true
    //     }
    // }
    tab name="btop" {
        pane {
            command "btop"
            borderless true
        }
    }
}

keybinds {
    shared {
        bind "Alt 1" { Run "git" "status"; }
        bind "Alt 2" { Run "git" "diff"; }
    }
}```

imsnif · 2023-12-01T11:46:09Z

Alright. Could you please find a minimal reproduction?

i-am-logger · 2023-12-01T11:46:23Z

yes, working on it

i-am-logger · 2023-12-01T11:47:34Z

it also seems that if i don't have the defalt_tab_template, the _hide_floating_panes is causing an error

i-am-logger · 2023-12-01T11:52:26Z

this is minimum without default_tab_template... this one fail with error

layout {
    tab focus=true hide_floating_panes=true {
        pane split_direction="vertical" {
            pane
        }
        pane split_direction="vertical" size=8 {
            pane
            pane
        }
        floating_panes {
            pane {
                x "10%"
                y "10%"
                width "80%"
                height "80%"
            }
        }
    }
}

this is minimum with default_tab_template

layout {
    default_tab_template {
        pane size=1 borderless=true {
            plugin location="zellij:tab-bar"
        }
        children
        pane size=2 borderless=true {
            plugin location="zellij:status-bar"
        }
    }

    tab focus=true hide_floating_panes=true {
        pane split_direction="vertical" {
            pane
        }
        pane split_direction="vertical" size=8 {
            pane
            pane
        }
        floating_panes {
            pane {
                x "10%"
                y "10%"
                width "80%"
                height "80%"
            }
        }
    }
}

i-am-logger · 2023-12-01T11:56:17Z

the most important for me is to be able to do keybinding to toggle a pane. not sure if its a feature to be added or already exists

i-am-logger · 2023-12-01T12:00:39Z

looks like the code samples doesn't work
https://zellij.dev/documentation/creating-a-layout#hide_floating_panes

layout {
    tab name="Tab #1" hide_floating_panes=true {
        pane
        pane
        floating_panes { // will start hidden
            pane
            pane
        }
    }
}

imsnif · 2023-12-01T12:52:39Z

Friend, respectfully: let's please try to keep the chatter here to a minimum. Otherwise it gets hard to get into context and understand what the issue is about when we try to fix it. The only thing I was able to reproduce from the layouts in this issue was the combination of default_tab_template and hide_floating_panes=true. Everything else works for me.

Please be sure you're on the latest version. If you find other issues, please report them with a minimal reproduction (thanks for finding one here) one issue per reported problem, and if you're unsure or need support, please ask on discords/matrix.

Thanks.

To recap, this issue is about the following layout not hiding floating panes, everything else works at the time of writing:

layout {
    default_tab_template {
        pane size=1 borderless=true {
            plugin location="zellij:tab-bar"
        }
        children
        pane size=2 borderless=true {
            plugin location="zellij:status-bar"
        }
    }

    tab hide_floating_panes=true {
        pane
        floating_panes {
            pane {
                x "10%"
                y "10%"
                width "80%"
                height "80%"
            }
        }
    }
}

propilideno · 2024-03-16T22:07:55Z

I have the same issue, to solve it temporarily i am repeating the code without using default_tab_template

cs-clarence · 2024-04-14T02:11:31Z

Same issue here, doesn't work with tab_template and new_tab_template as well.

rockboynton · 2024-05-18T22:41:49Z

I have the issue with default_tab_template, but it seems to work with new_tab_template. Actually, I think the issue is hide_floating_panes=true doesn't work for predefined tab layouts.

Armadillidiid · 2024-08-12T07:39:52Z

Just encountered this issue. hide_floating_panes=true doesn't work when used along default tab layouts.

jwkicklighter · 2024-10-09T20:44:30Z

I am having this same issue.

i-am-logger added the suspected bug label Dec 1, 2023

imsnif changed the title ~~hide_floating_panes doesn't seem to work~~ hide_floating_panes doesn't work with a default_tab_template Dec 1, 2023

zhyuri linked a pull request Dec 6, 2024 that will close this issue

Set hide_floating_panes in parse_tab_node_with_template #3846

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

hide_floating_panes doesn't work with a `default_tab_template` #2974

hide_floating_panes doesn't work with a `default_tab_template` #2974

i-am-logger commented Dec 1, 2023 •

edited

Loading

imsnif commented Dec 1, 2023

i-am-logger commented Dec 1, 2023

imsnif commented Dec 1, 2023

i-am-logger commented Dec 1, 2023

i-am-logger commented Dec 1, 2023

i-am-logger commented Dec 1, 2023 •

edited

Loading

i-am-logger commented Dec 1, 2023

i-am-logger commented Dec 1, 2023

imsnif commented Dec 1, 2023

propilideno commented Mar 16, 2024

cs-clarence commented Apr 14, 2024

rockboynton commented May 18, 2024 •

edited

Loading

Armadillidiid commented Aug 12, 2024

jwkicklighter commented Oct 9, 2024

hide_floating_panes doesn't work with a default_tab_template #2974

hide_floating_panes doesn't work with a default_tab_template #2974

Comments

i-am-logger commented Dec 1, 2023 • edited Loading

imsnif commented Dec 1, 2023

i-am-logger commented Dec 1, 2023

imsnif commented Dec 1, 2023

i-am-logger commented Dec 1, 2023

i-am-logger commented Dec 1, 2023

i-am-logger commented Dec 1, 2023 • edited Loading

i-am-logger commented Dec 1, 2023

i-am-logger commented Dec 1, 2023

imsnif commented Dec 1, 2023

propilideno commented Mar 16, 2024

cs-clarence commented Apr 14, 2024

rockboynton commented May 18, 2024 • edited Loading

Armadillidiid commented Aug 12, 2024

jwkicklighter commented Oct 9, 2024

hide_floating_panes doesn't work with a `default_tab_template` #2974

hide_floating_panes doesn't work with a `default_tab_template` #2974

i-am-logger commented Dec 1, 2023 •

edited

Loading

i-am-logger commented Dec 1, 2023 •

edited

Loading

rockboynton commented May 18, 2024 •

edited

Loading