Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid noisy logging for packages that intentionally don't have any zkg.meta-specified scripts #199

Open
ckreibich opened this issue Oct 18, 2024 · 1 comment

Comments

@ckreibich
Copy link
Member

@J-Gras hit a situation in which a package is content to only ship Zeek scripts with a contained plugin, not (also) via zkg.meta's script_dir. Leaving out that directive and not providing any Zeek scripts at the toplevel leads to:

WARNING  installing "/mypath": no __load__.zeek in implicit script_dir, skipped installing scripts

We have other such packages in the collection, too. Seems fine to just remove the warning, or demote it to debug level. Note that there's a related warning that would be good to confirm/check in this context, here.

@ckreibich ckreibich changed the title Support packages that intentionally don't have any zkg.meta-specified scripts Avoid noisy logging for packages that intentionally don't have any zkg.meta-specified scripts Oct 18, 2024
@J-Gras
Copy link
Contributor

J-Gras commented Oct 18, 2024

Another option might be to keep the warning but allow explicitly unsetting the value (e.g. script_dir=<none>).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants