Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calling ownTexts is slow. #50

Open
mircealungu opened this issue Mar 14, 2024 · 1 comment
Open

calling ownTexts is slow. #50

mircealungu opened this issue Mar 14, 2024 · 1 comment
Assignees
@mircealungu @tfnribeiro

Comments

@mircealungu
Copy link
Member

It seems that when starting the reader we're calling the own_texts endpoint.
it is very slow - we should see why it's slow... but that's not the problem. the problem is that we're calling it at all. it's not clear why is it needed when starting to render a given article.

image

we should look into this.
Mlth pushed a commit to Mlth/zeeguu-browser-extension that referenced this issue Mar 19, 2024
@mircealungu
this has been already assigned in line zeeguu#50; which is almost as …
11e31d9 
…soon as we have the session ID; just to make it even closer to the moment when we have the sessionID - i've moved that one to line zeeguu#44.
@tfnribeiro
Copy link
Contributor

OwnTexts is called because the reader needs to determine if the article has been saved so the article is rendered accordingly - this could be improved by just having a isArticleSavedForUser or something similar, where we only query 1 text rather than the entire list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mircealungu mircealungu

@tfnribeiro tfnribeiro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

50-calling-owntexts-is-slow zeeguu/browser-extension
2 participants
@mircealungu @tfnribeiro