Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unifying Save UI #44

Open
mircealungu opened this issue Feb 10, 2024 · 4 comments
Open

Unifying Save UI #44

mircealungu opened this issue Feb 10, 2024 · 4 comments
Assignees

Comments

@mircealungu
Copy link
Member

mircealungu commented Feb 10, 2024

Between this:
image

And this:
image

The second is better also, because the first does not make sense to be still visible when the article is not visible, e.g. in word review, or exercises:

image

Do you see what I mean? Do you agree @tfnribeiro @DarinkaGM ?

@tfnribeiro
Copy link
Contributor

If I understood correctly, the point is to make the Save icon look the same in the preview as it does now for the Extension reader?

And the second point is to remove the save option if we are in the word/screen exercises? I think yes, that makes sense!

I have one question. Since I am adding the functionality to remove saved articles, I probably will have to overwrite the tooltip saying that it's saved, or do we leave that functionality to only be shown from the app side?

@mircealungu
Copy link
Member Author

Yes. You understood correctly Tiago!

I guess if we unify the Saved behavior across the app it is going to be more understandable?

@tfnribeiro
Copy link
Contributor

Something like this?

image

image

image

@mircealungu
Copy link
Member Author

I think that should be a nice start!
We will still have to spend some time unifying the two readers but that will be a problem for later I'd say.

mircealungu added a commit that referenced this issue Mar 6, 2024
…s we have the session ID; just to make it even closer to the moment when we have the sessionID - i've moved that one to line #44.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants