-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unifying Save UI #44
Comments
If I understood correctly, the point is to make the Save icon look the same in the preview as it does now for the Extension reader? And the second point is to remove the save option if we are in the word/screen exercises? I think yes, that makes sense! I have one question. Since I am adding the functionality to remove saved articles, I probably will have to overwrite the tooltip saying that it's saved, or do we leave that functionality to only be shown from the app side? |
Yes. You understood correctly Tiago! I guess if we unify the Saved behavior across the app it is going to be more understandable? |
I think that should be a nice start! |
…s we have the session ID; just to make it even closer to the moment when we have the sessionID - i've moved that one to line #44.
Between this:
And this:
The second is better also, because the first does not make sense to be still visible when the article is not visible, e.g. in word review, or exercises:
Do you see what I mean? Do you agree @tfnribeiro @DarinkaGM ?
The text was updated successfully, but these errors were encountered: