Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design: Text "signals" (diagnostics, suggestions) #1447

Closed
11 tasks
iamnbutler opened this issue Aug 2, 2022 · 0 comments
Closed
11 tasks

Design: Text "signals" (diagnostics, suggestions) #1447

iamnbutler opened this issue Aug 2, 2022 · 0 comments
Labels
design [core label]

Comments

@iamnbutler
Copy link
Member

iamnbutler commented Aug 2, 2022 •
edited
Loading

(Note: The name "signal" comes from the idea of traffic signals. We think this could be a reasonable name to call this family of things, but open to other more appropriate terms.)

Blocks https://github.com/zed-industries/feedback/issues/275

Design a unified system for signals.

Signals are indicators on a piece of text that there is some secondary problem, suggestion, or feedback.

  • Design a spec for text signals
  • Create a hierarchy for signal importance (error has priority over spelling, for example.)
  • Explore what happens when signals conflict
  • Specs for each signal:
    • Error
    • Warning
    • Info (Q: What uses this? Can we understand better)
    • Spell check
    • Grammer/prose suggestion
    • Code suggestion/Code action

Inline suggestions/autocomplete isn't a signal, but should we consider it at the same time? Does it have similar properties?

  • Decide if inline suggestions/autocomplete should be included in signal spec.

Questions:

  • Do signals show up on all surfaces all the time? Or are some signals shown all the time and others only on the focused tab or buffer?
@iamnbutler iamnbutler added the design [core label] label Aug 2, 2022
ConradIrwin added a commit that referenced this issue Jul 7, 2023
@ConradIrwin
vim: keymap tweaks (#2674)
362023c 
A few small tweaks to fix some of the community issues

Release Notes:

- vim: Fix `escape` in command palette
([#1347](https://github.com/zed-industries/community/issues/1347)).
- vim: Allow `^` as a motion in actions
([#856](https://github.com/zed-industries/community/issues/856)).
- vim: Allow `ctrl-c` to exit visual mode
([#1447](https://github.com/zed-industries/community/issues/1447)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design [core label]
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iamnbutler