Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LICENSE files in package subdirs #57

Open
schwa423 opened this issue Mar 28, 2022 · 3 comments
Open

LICENSE files in package subdirs #57

schwa423 opened this issue Mar 28, 2022 · 3 comments

Comments

@schwa423
Copy link

schwa423 commented Mar 28, 2022

Background:

Hello, the Fuchsia project vendors crates from crates.io, and in order to do so we require explicit license files alongside the source code. Here is the policy: https://fuchsia.dev/fuchsia-src/contribute/governance/policy/open-source-licensing-policies?hl=en#licenses_and_tracking . In particular, reading the SPDX package/license field from the crate's Cargo.toml is not good enough.

Request:

Could you please add LICENSE-* files to the package subdirectories, specifically gpu-alloc and types (although you might as well do it for all package dirs that are uploaded to crates.io)?

We are currently using gpu-alloc 0.5.3 and gpu-alloc-types 0.2.0. Since crates.io doesn't allow re-uploading the same version with a modified crate, it seems the right thing to do is to upload new crates with versions 0.5.4 and 0.2.1 respectively.

I'd appreciate if you're able to do this, since I have to file similar issues for many other crate dependencies. But if you don't have the bandwidth to address this issue, please let me know and I'll find time to submit a pull request (although of course I won't be able to upload anything to crates.io)

@zakarumych
Copy link
Owner

Hello.

What do you specifically mean by "crate doesn't have a LICENSE (or LICENSE-APACHE, etc.) file"?
Do you refer to license-file field in Cargo.toml? If so, wouldn't it be better to reference existing license files there?
Otherwise, please, explain how license files in each crate directory would help.

@schwa423
Copy link
Author

Hi, thanks for the quick response. No, I don't mean the field in Cargo.toml; I mean a separate file (e.g. LICENSE-MIT) that is uploaded with the rest of the crate files to crates.io. For example, consider:
https://github.com/RustCrypto/signatures/tree/master/ecdsa
... the LICENSE-APACHE and LICENSE-MIT files were added so that they appear in crates.io, even though copies of those files also exist in the repository root directory.

The reason for this request is that we currently only have legal sign-off for LICENSE-* files, not to read the license out of Cargo.toml metadata. It might seem silly to you and me, but that's the current state of things.

@schwa423
Copy link
Author

I modified the issue description to contain a link to our licensing policy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants