Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Sort by rising" sorts by new instead of rising #78

Open
Jolt151 opened this issue Jul 19, 2018 · 4 comments
Open

"Sort by rising" sorts by new instead of rising #78

Jolt151 opened this issue Jul 19, 2018 · 4 comments

Comments

@Jolt151
Copy link

Jolt151 commented Jul 19, 2018

Pics:
diode: https://i.imgur.com/E9X13Sw.png
browser: https://i.imgur.com/yYqMyBW.png

@zagaberoo
Copy link
Owner

Thanks for the report.

This should be a very easy fix. Either that, or it'll be too much trouble for me to diagnose. I'll take a look in the next week or so and we'll find out!

@zagaberoo
Copy link
Owner

Aha, looks like it's just because diode doesn't support rising sort

screenshot_20180804-171522

So you must be clicking on a link to rising from outside diode, yeah?

In any case, since this is more of a missing feature than a bug, a change won't be made unless someone decides to implement it and submit the code.

@zagaberoo zagaberoo changed the title "Sort by rising" sorts by new instead of rising Add support for "rising" sort Aug 5, 2018
@Jolt151
Copy link
Author

Jolt151 commented Aug 5, 2018

If you click on new, you get an option to choose between new and rising.

@zagaberoo
Copy link
Owner

Yep, you're totally right. As you can probably tell I'm just the steward of this code rather than the author (it used to be Reddit is Fun back in the day before the source was closed).

The rising feature does seem to be bugged, so I'll put it back in the queue to get examined.

@zagaberoo zagaberoo changed the title Add support for "rising" sort "Sort by rising" sorts by new instead of rising Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants