Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add infinite scroll and lazy loading in icpump.fun listing page #571

Open
harshita-srivastava-yral opened this issue Jan 3, 2025 · 3 comments · May be fixed by #577
Open

Add infinite scroll and lazy loading in icpump.fun listing page #571

harshita-srivastava-yral opened this issue Jan 3, 2025 · 3 comments · May be fixed by #577
Assignees
@vishnu-shankar-yral
Labels
enhancement New feature or request

Comments

@harshita-srivastava-yral
Copy link
Contributor

harshita-srivastava-yral commented Jan 3, 2025 •
edited
Loading

Behaviour today: When a user clicks on the page numbers we load the new set of token listing for the user

Behaviour expected: When user scrolls lazy load the page and ensure its an infinite scroll.

Figma for skeleton loading: https://www.figma.com/design/qly4tjTKMMbdOO4IrLzOeC/Icpump-designs?node-id=1293-3340&t=TZHCyuJpPvV50Nl0-4
@harshita-srivastava-yral harshita-srivastava-yral added the enhancement New feature or request label Jan 3, 2025
@harshita-srivastava-yral harshita-srivastava-yral changed the title Add lazy loading in icpump.fun listing page Add infinite scroll and lazy loading in icpump.fun listing page Jan 3, 2025
@vishnu-shankar-yral
Copy link
Contributor

vishnu-shankar-yral commented Jan 6, 2025 •
edited
Loading

  • Loading component
  • Remove pagination
  • Add intersection observer to last card
  • Fix CSS issues that cause intersection observer to trigger at start
  • Add lazy loading
  • Figure out how to end the feed
  • Clean up

@vishnu-shankar-yral vishnu-shankar-yral linked a pull request Jan 6, 2025 that will close this issue
Add infinite scrolling and lazy loading for icpump.fun listing page #577
Open
@vishnu-shankar-yral
Copy link
Contributor

Preview link at: https://pr-577-yral-dapp-hot-or-not-web-leptos-ssr.fly.dev/board

@harshita-srivastava-yral
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vishnu-shankar-yral vishnu-shankar-yral

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@harshita-srivastava-yral @vishnu-shankar-yral