Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regional differences in decimal separator #3

Open
GoogleCodeExporter opened this issue Mar 30, 2016 · 1 comment
Open

Regional differences in decimal separator #3

GoogleCodeExporter opened this issue Mar 30, 2016 · 1 comment

Comments

@GoogleCodeExporter
Copy link

Some matching assumes . for decimal separator, which is not the case in 
some regions. 

FitMatcher.pas uses two regular expressions to match comparative results:

line 72:
  p := '^\s*_?\s*(<|>|<=|>=)\s*([-+]?[\d]*\.?[\d]+)';

line 108:
  p := '^\s*([-+]?[\d]*\.?[\d]+)\s*(<|>|<=|>=)\s*_\s*(<|>|<=|>=)\s*([-+]?
[\d]*\.?[\d]+)';

The three dot's should be replaced with references to the global variable 
DecimalSeparator. Something like this:

line 72:
  p := '^\s*_?\s*(<|>|<=|>=)\s*([-+]?[\d]*\' + DecimalSeparator + '?
[\d]+)';

line 108:
  p := '^\s*([-+]?[\d]*\' + DecimalSeparator + '?[\d]+)\s*(<|>|<=|>=)\s*_
\s*(<|>|<=|>=)\s*([-+]?[\d]*\' + DecimalSeparator + '?[\d]+)';

regards,
-Vegar

Original issue reported on code.google.com by vegar%[email protected] on 27 Aug 2009 at 7:07

@GoogleCodeExporter
Copy link
Author

You are right that this should be system specific, but I want to keep code as 
close
as possible to original Java version.

Original comment by [email protected] on 27 Aug 2009 at 10:51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant