Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Hide link icon there's no description. #145

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Conversation

udgover
Copy link
Collaborator

@udgover udgover commented Jan 29, 2024

Show link type when there's no description. Add information icon only when description

When there is a description, information icon is appended to link type and the button is clickable to see the description's content:

Screenshot 2024-01-29 at 10 30 54

When there's no description, only displays the link type with disabled button and without information icon.

Screenshot 2024-01-29 at 10 30 31

@udgover udgover requested a review from tomchop January 29, 2024 09:33
@tomchop tomchop merged commit 08653cf into main Jan 29, 2024
1 check passed
@tomchop tomchop deleted the always_show_link_type branch January 29, 2024 13:55
@tomchop tomchop added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Jan 29, 2024
@tomchop tomchop changed the title Show link type when there's no description. Add information icon only… Fix: Hide link icon there's no description. Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants