diagnostics.test.vim fail when running with Vim v9.1.0949 or newer

[jamessan]

Issue Prelude

Please complete these steps and check these boxes (by putting an x inside
the brackets) before filing your issue:

• I have read and understood YCM's CONTRIBUTING document.
• I have read and understood YCM's CODE_OF_CONDUCT document.
• I have read and understood YCM's README, especially the
  Frequently Asked Questions section.
• I have searched YCM's issue tracker to find issues similar to the one I'm
  about to report and couldn't find an answer to my problem. (Example Google
  search.)
• If filing a bug report, I have included the output of vim --version.
• If filing a bug report, I have included the output of :YcmDebugInfo.
• If filing a bug report, I have attached the contents of the logfiles using
  the :YcmToggleLogs command.
• If filing a bug report, I have included which OS (including specific OS
  version) I am using.
• If filing a bug report, I have included a minimal test case that reproduces
  my issue, using vim -Nu /path/to/YCM/vimrc_ycm_minimal, including what I
  expected to happen and what actually happened.
• If filing a installation failure report, I have included the entire output
  of install.py (or cmake/make/ninja) including its invocation
• I understand this is an open-source project staffed by volunteers and
  that any help I receive is a selfless, heartfelt gift of their free time. I
  know I am not entitled to anything and will be polite and courteous.
• I understand my issue may be closed if it becomes obvious I didn't
  actually perform all of these steps.

Thank you for adhering to this process! It ensures your issue is resolved
quickly and that neither your nor our time is needlessly wasted.

Issue Details

• What did you do?

After updating the Vim package in Debian, the vim-youcompleteme package's tests started failing. I bisected the issue to @bstaletic's Vim patch v9.1.0949.

This might be related to the discussion that spawned after the patch was merged.

1. Install v9.1.0949 or newer Vim
2. Run ./test/run_vim_tests diagnostics.test.vim

• What did you expect to happen?

All tests pass

• What actually happened?

Test_ShowDetailedDiagnostic_Popup_MultilineDiagFromStartOfLine and Test_ShowDetailedDiagnostic_Popup_MultilineDiagNotFromStartOfLine fail. Debug logs are available in this gist.

[puremourning]

Thanks for the report.

Ironically this seems like a vim bug not a YCM one though right (Dramatis personae notwithstanding)?

[jamessan]

I wasn't sure which side of the fence the issue would land on, but figured it was at least worth having it known here.

[puremourning]

Yeah it makes sense. I think we can check it and transfer if needed. Thanks.