Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Unsaved dashboard changes" dialog is not shown when navigating directly to a different dashboard #1641

Open
daniellevinson opened this issue May 25, 2022 · 0 comments
Labels

Comments

@daniellevinson
Copy link
Member

Describe the bug
It's probably not a likely scenario, but if you navigate from an unsaved dashboard directly to a different dashboard, the dialog is not shown.
The fix might be easier than writing this ticket (copying/moving the dashboard id comparison from cacheQuery to willTransition https://github.com/yavin-dev/framework/blob/master/packages/dashboards/addon/routes/dashboards/dashboard.ts#L232)
but probably requires some more thorough testing to see that nothing else breaks.

To Reproduce

  1. Go to https://yavin-dev.github.io/framework/#/dashboards/2/view
  2. Click on Home (breadcrumb link)
  3. Go to Coin Health Check dashboard
  4. Add "Coin counts" to dashboard
  5. Don't save ☠️
  6. Navigate directly 2 steps back to dashboard 2

Screen Shot 2022-05-25 at 1 24 11 PM

Expected behavior
Show dialog unless same dashboard id.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant