Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a title attribute to required columns/filters remove buttons #1301

Open
kevinhinterlong opened this issue Mar 18, 2021 · 0 comments
Open

Add a title attribute to required columns/filters remove buttons #1301

kevinhinterlong opened this issue Mar 18, 2021 · 0 comments
Labels
Hacktoberfest Hacktoberfest HackTogether

Comments

@kevinhinterlong
Copy link
Member

Add title="This (Column|Filter) is required" message to the disabled remove button on required columns/filters to show why they are disabled

framework/packages/reports/addon/components/filter-collection.hbs

Line 23 in 5f55675

disabled={{filter.isRequired}}

framework/packages/reports/addon/components/navi-column-config/item.hbs

Line 16 in 1735bd3

disabled={{@column.isRequired}}

@jkusa jkusa added the Hacktoberfest Hacktoberfest label Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Hacktoberfest Hacktoberfest HackTogether
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jkusa @kevinhinterlong