Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug for activeHeight < 15 and length = 2 #6

Open
dchaebae opened this issue Jun 20, 2020 · 5 comments
Open

Bug for activeHeight < 15 and length = 2 #6

dchaebae opened this issue Jun 20, 2020 · 5 comments
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@dchaebae
Copy link

Hi,

When length is set to 2 (width,height=15), then the right dot is clipped, as shown in the image.
Screen Shot 2020-06-20 at 11 24 41 AM

Setting width, height to match the default for non-active (width,height=10), makes the dot offset in the Y.
Screen Shot 2020-06-20 at 11 24 00 AM

@yasaricli yasaricli self-assigned this Jun 22, 2020
@yasaricli yasaricli added the bug Something isn't working label Jun 22, 2020
@yasaricli
Copy link
Owner

hello @dchaebae

I plan to have a look at this issue in a couple days and it should be resolved with the next release.

thanks.

@dchaebae
Copy link
Author

Sounds good, thanks!

@yasaricli yasaricli added the help wanted Extra attention is needed label Aug 18, 2020
@sentientmachin3
Copy link

I'm still facing this issue, using 4 dots and having the 3rd selected. Here's how I use it:

<View style={styles.dots}>
    <Dots length={4} active={3} activeColor={Colors.accent} passiveColor={Colors.disabledTextColor} />
</View>

which is fairly simple. I tried several configs, messing with activeDotWidth/Height but didn't find a solution.

@yasaricli yasaricli reopened this Feb 8, 2021
@yasaricli
Copy link
Owner

@sentientmachin3 Can you share an image about it?

@ammarfaris
Copy link

by default, currently, it already makes the dot offset in the Y-axis like the original poster stated and like the image shown for all platforms (ios, android, react-native-web) ... @yasaricli

versions:
Screenshot 2023-09-06 at 2 30 13 PM

"expo": "~49.0.7",
"react-native": "0.72.4",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants