Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Jaeger reporter and sampler customizations #234

Open
yurishkuro opened this issue Jun 8, 2018 · 0 comments
Open

Remove Jaeger reporter and sampler customizations #234

yurishkuro opened this issue Jun 8, 2018 · 0 comments

Comments

@yurishkuro
Copy link

https://github.com/yarpc/yab/pull/233/files#diff-7ddfb3e035b42cd70649cc33393fe32cR381

I recommend removing these two lines and using the default sampler and reporter.

The choice of sampler should have little effect since yab forces sampling via sampling.priority tag anyway, so no reason to have that customization.

The reason for using null reported is a mystery to me, it causes top-level span of the trace not being reported even when they could've been, e.g. when yab is run on a production host. There's no harm in running with the default (remote) reporter here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant