Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Malformed outline on panel #749

Open
3 tasks done
bobatsar opened this issue Oct 11, 2024 · 3 comments
Open
3 tasks done

Malformed outline on panel #749

bobatsar opened this issue Oct 11, 2024 · 3 comments

Comments

@bobatsar
Copy link

Prerequisites

  • I have read FAQ
  • I have searched existing issues (including closed ones)
  • I use KiKit at least version 1.6.0 (older version are not supported)

KiKit version

kikit, version 1.6.0+7.g309b937

KiCAD version

8.0.5

Operating system

Ubuntu 24.04

Description

A outline imported from dxf files is unfortunately malformed in the resulting panel.

test_outline:
Bildschirmfoto vom 2024-10-11 10-36-18

The input outlines render normally in the PCB-3D viewer (correct closed outline for KiCad).
test_outline

but the resulting panel is messed up.
Bildschirmfoto vom 2024-10-11 11-04-48

Steps to Reproduce

Use the example pcbs in

kikit_malformed_outline.zip

and run e.g.

kikit panelize \
    --layout 'grid; rows: 2; cols: 2;' \
    --tabs full \
    --cuts vcuts \
    test_outline.kicad_pcb panel_outline.kicad_pcb
@bobatsar
Copy link
Author

@yaqwsx is there more input required to handle this case? Can I provide more data for debugging or can you help me debug this myself?

It would be very helpful for us to fix this bug.

@yaqwsx
Copy link
Owner

yaqwsx commented Nov 12, 2024

I can confirm it is the same issue as #750. It is a bug in the full tabs generator. Similarly to the author of #750, I believe you don't don't to actually use the full tabs (as they would completely cover the shape of your PCB). Use fixed or annotation tabs instead.

@greenscreenflicker
Copy link

it seems that the full tab generator works when the tab side is a plain line.
If you can't find a clever solution with the script (which is obviously to prefer), it would be good to output a warning message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants