This repository has been archived by the owner on Oct 30, 2018. It is now read-only.
improve error handling and messaging #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notify the user with more meaningful messages when trying to run mojits that don't exist or are not configured correctly.
|
This also solves a production problem for us, where we might see an error log like but don't know which mojit should have been executed and therefore don't know what might be going on. After this PR we'll see the name of the Mojit that failed: |
|
+1 though not sure why a store unit test is failing on Travis (node .8 only) |
|
@isao it seems we are good to merge ;-) |
isao
pushed a commit
that referenced
this pull request
Sep 12, 2012
improve error handling and messaging thanks @FabianFrank
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
notify the user with more meaningful messages when trying to run mojits that don't exist or are not configured correctly.