-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update list of GridStack actions #60
Comments
@adumesny Does GridStack have a list of these events anywhere in the code or should we just update our own list? |
there is a type (which is enforced with Typescript version) but not an array of them. type GridStackEvent = 'added' | 'change' | 'disable' | 'dragstart' | 'dragstop' | 'dropped' | I added string (anything) as you can combine them into a space separated list (not sure how to do enforce that type option) as of 1.1.0 (which jquery supported). I update the demos to use it. https://github.com/gridstack/gridstack.js/blob/develop/src/gridstack.d.ts Note: master is unfortunately not always latest published... I try to keep it up when releasing but develop is it. |
but maybe I should expose an array of them for others to use ? I don't expect those to change often. |
This is what I assumed, so maybe we'll just update this repo's list of events and have to be more careful in the future updates. Or if you do add a list of events we could use that and you could add them as an assert to runtime typecheck on the space separated list |
@adumesny out of curiosity, from a gridstack client perspective, is there a need for both |
so only if you care about those fields being set. Personally I use the node values... |
Discussion from 065d92d#r37636891
Here is a list of events
The text was updated successfully, but these errors were encountered: