Burst never used.

[KeinPfusch]

Seems Burst is never used.I used it with burst, but no effect.

So I went into the code, and I can't find the implementation. Is there something I am missing?

[magikstm]

Could you please describe the issue a bit more or share your caddyfile?

Burst seems to be implemented in the current build:

Ref:

caddy-rate-limit/ratelimit.go

Line 22 in e94764d

Burst int

caddy-rate-limit/caddylimiter_test.go

Line 23 in e94764d

[]string{"127.0.0.1", "get", "", "/"}, Rule{Methods: "", Status: "", Rate: 2, Burst: 2, Unit: "second"}, 2, 0, false, true,

Demos:
https://github.com/xuqingfeng/caddy-rate-limit/blob/master/test_site/minute/index.html
https://github.com/xuqingfeng/caddy-rate-limit/blob/master/test_site/file/config.txt

[KeinPfusch]

Yes. I see there is one variable, which is read from config.

Let me explain better. According with the time/rate library, the burst represents the amount of events you may have in the same time, to descale the pool you have.

But, the way this module is using it, you receive ONE http call at a time. Which is what is passed for each call. So when I set a burst , it doesn't affects the behaviour. I noticed to change the burst was not affecting the behaviour, so I tried to understand how the burst variable is used.

Actually is not. Sure, Burst is there. But having one http request per time, is never being used. So I can set burst to 10 or to 1000 and the behaviour doesn't changes. Pool is always decreased of 1, apparently.