You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If the maintainers of the repo are open to pull requests, would they be interested in a pull request for code cleanup and some production level updates? There are a lot of things in the code that just don't make sense, such as setting the max sequence length and then checking the max sequence length, or neurotically sending models to devices. This isn't great for a more production level deployment when we want to embed millions or billions of documents.
I am going to be making these changes, but I don't want to fork and diverge from the repo. I'd rather that my work be pulled into this repo so that I not only don't have to worry about downstream updates but also it will benefit anyone that uses this.
The text was updated successfully, but these errors were encountered:
If the maintainers of the repo are open to pull requests, would they be interested in a pull request for code cleanup and some production level updates? There are a lot of things in the code that just don't make sense, such as setting the max sequence length and then checking the max sequence length, or neurotically sending models to devices. This isn't great for a more production level deployment when we want to embed millions or billions of documents.
I am going to be making these changes, but I don't want to fork and diverge from the repo. I'd rather that my work be pulled into this repo so that I not only don't have to worry about downstream updates but also it will benefit anyone that uses this.
The text was updated successfully, but these errors were encountered: