Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random edge position for dyads? #396

Closed
nwlandry opened this issue Jun 9, 2023 · 1 comment · Fixed by #476
Closed

Random edge position for dyads? #396

nwlandry opened this issue Jun 9, 2023 · 1 comment · Fixed by #476
Labels

Comments

@nwlandry
Copy link
Collaborator

nwlandry commented Jun 9, 2023

I was noticing that the edge positions of dyads is random and not according to the spring layout:
Screenshot 2023-06-09 at 8 42 21 AM
I think this is because spring layout is using _augmented_projection which excludes dyads.

Is this desired behavior, or should we use convert.to_bipartite_graph so that dyads also have nodes?

@thomasrobiglio
Copy link
Collaborator

Actually the positions are computed after adding phantom nodes also for dyads, but those added phantom nodes make it so that the positions that are assigned are different than those that would be assigned if we used the spring_layout on the hypergraph obtained by converting the DH.

Anyway it would be nice to modify the draw_dihypergraph function in order to take a pos like the other drawing functions (it would allow e.g. to draw a DH and its skeleton/converted HG with the same positions and/or to use the different layouts we have).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants