Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interval entry fields disappear if filled with invalid data #480

Closed
frostburn opened this issue Nov 18, 2023 · 0 comments · Fixed by #481
Closed

Interval entry fields disappear if filled with invalid data #480

frostburn opened this issue Nov 18, 2023 · 0 comments · Fixed by #481
Labels
bug Something isn't working

Comments

@frostburn
Copy link
Member

To reproduce

  1. Open New Scale -> Equal Temperament
  2. Enter something invalid for the Interval to divide
  3. Press Cancel
  4. Reopen the modal

Expected behaviour

The input field retains the content.

Observed behaviour

The input field disappears from the layout with a corresponding error in the browser console.
@frostburn frostburn added the bug Something isn't working label Nov 18, 2023
frostburn added a commit that referenced this issue Nov 18, 2023
@frostburn
Make the default value a required prop for ScaleLineInput
0eeda2f 
ref #480
@frostburn frostburn linked a pull request Nov 18, 2023 that will close this issue
Fix scale line input #481
Merged
frostburn added a commit that referenced this issue Nov 26, 2023
@frostburn
Make the default value a required prop for ScaleLineInput
4331fc8 
ref #480
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix scale line input xenharmonic-devs/scale-workshop
1 participant
@frostburn