Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sorting causes composite intervals to be respelled #420

Closed
frostburn opened this issue Apr 21, 2023 · 1 comment · Fixed by #431
Closed

Sorting causes composite intervals to be respelled #420

frostburn opened this issue Apr 21, 2023 · 1 comment · Fixed by #431
Labels
bug Something isn't working
Milestone
2.1.2

Comments

@frostburn
Copy link
Member

Composite intervals get respelled when sorting e.g. 13/8 - 3/2 becomes 13/12 , making them harder to recognize and losing information about the intention.
@frostburn frostburn added the bug Something isn't working label Apr 21, 2023
@frostburn frostburn added this to the 2.1.1 milestone Apr 27, 2023
frostburn added a commit to xenharmonic-devs/scale-workshop-core that referenced this issue Apr 27, 2023
@frostburn
Implement reverse parsing that preserves interval names when possible
4abed1f 
ref xenharmonic-devs/scale-workshop#420
@frostburn
Copy link
Member Author

Core functionality added: xenharmonic-devs/scale-workshop-core@4abed1f

frostburn added a commit that referenced this issue May 3, 2023
@frostburn
Use name preserving reverse parsing when modifying scales
c921a6b 
ref #420
@frostburn frostburn mentioned this issue May 3, 2023
Merged
@frostburn frostburn linked a pull request May 3, 2023 that will close this issue
Use name preserving reverse parsing when modifying scales #431
Merged
frostburn added a commit that referenced this issue May 3, 2023
@frostburn
Use name preserving reverse parsing when modifying scales
8bb6bd2 
ref #420
frostburn added a commit that referenced this issue Nov 26, 2023
@frostburn
Use name preserving reverse parsing when modifying scales
6bef377 
ref #420
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
2.1.2
Development

Successfully merging a pull request may close this issue.

Use name preserving reverse parsing when modifying scales xenharmonic-devs/scale-workshop
1 participant
@frostburn