You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Accidentally noticed this when I thought I was setting base frequency input field but instead was focused on MIDI note for base frequency input field. Any decimal values other than 0 will cause the screen to go black, clicking somewhere in the browser window will bring the page back with the scale output table missing. When running in local development environment, there is no UI bug but the MIDI note number displays undefined for midi note name and a float for the octave number.
Updating emit args for baseMidiNote (line 103 in ScaleBuilder.vue) to Math.trunc(newValue) provides a quick fix that handles decimal values the same way other invalid characters are handled. Unit tests pass and e2e tests appear unaffected by the change.
The text was updated successfully, but these errors were encountered:
Accidentally noticed this when I thought I was setting base frequency input field but instead was focused on MIDI note for base frequency input field. Any decimal values other than 0 will cause the screen to go black, clicking somewhere in the browser window will bring the page back with the scale output table missing. When running in local development environment, there is no UI bug but the MIDI note number displays undefined for midi note name and a float for the octave number.
Updating emit args for
baseMidiNote
(line 103 inScaleBuilder.vue
) toMath.trunc(newValue)
provides a quick fix that handles decimal values the same way other invalid characters are handled. Unit tests pass and e2e tests appear unaffected by the change.The text was updated successfully, but these errors were encountered: