Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing float for MIDI note number sometimes causes black screen #416

Closed
rlh74 opened this issue Apr 16, 2023 · 0 comments · Fixed by #422
Closed

Passing float for MIDI note number sometimes causes black screen #416

rlh74 opened this issue Apr 16, 2023 · 0 comments · Fixed by #422
Labels
bug Something isn't working
Milestone

Comments

@rlh74
Copy link

rlh74 commented Apr 16, 2023

Accidentally noticed this when I thought I was setting base frequency input field but instead was focused on MIDI note for base frequency input field. Any decimal values other than 0 will cause the screen to go black, clicking somewhere in the browser window will bring the page back with the scale output table missing. When running in local development environment, there is no UI bug but the MIDI note number displays undefined for midi note name and a float for the octave number.

Updating emit args for baseMidiNote (line 103 in ScaleBuilder.vue) to Math.trunc(newValue) provides a quick fix that handles decimal values the same way other invalid characters are handled. Unit tests pass and e2e tests appear unaffected by the change.

@frostburn frostburn added the bug Something isn't working label Apr 17, 2023
@frostburn frostburn added this to the 2.1.1 milestone Apr 27, 2023
frostburn added a commit that referenced this issue Apr 27, 2023
@frostburn frostburn linked a pull request Apr 27, 2023 that will close this issue
frostburn added a commit that referenced this issue Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants