Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interval matrix shows 1/1 when mixing cents and ratios #412

Closed
frostburn opened this issue Mar 25, 2023 · 2 comments · Fixed by #433
Closed

Interval matrix shows 1/1 when mixing cents and ratios #412

frostburn opened this issue Mar 25, 2023 · 2 comments · Fixed by #433
Labels
bug Something isn't working
Milestone

Comments

@frostburn
Copy link
Member

fredg999 — Today at 5:39 AM

I think I found a bug in SW's interval matrix (Analysis tab). Here's an example of scale that triggers it: https://sevish.com/scaleworkshop/analysis?l=5k._b4._dw._jg._p0._uk._2F1&version=2.0.1
The "default" display shows 1/1 for a bunch of intervals (roughly the top-left half, diagonally), whereas the "cents" and "decimal ratio" displays show the correct values in each cell.
The bug seems to be associated with the mixed use of cents and ratios (2/1 for the octave, but cents for the rest). Replacing 2/1 with 1200. is a possible workaround, but I know that many Scala files (as found in the Scala scale archive, for example) are formatted like this, with many cents values and then a 2/1 for the octave, so I think this bug might be encountered by other people under "normal" circumstances.

@frostburn frostburn added the bug Something isn't working label Mar 25, 2023
@frostburn frostburn added this to the 2.1.1 milestone Apr 27, 2023
frostburn added a commit to xenharmonic-devs/scale-workshop-core that referenced this issue Apr 27, 2023
@frostburn
Copy link
Member Author

I think this was an issue in the core where intervals within the scale got 1/1 added by accident: xenharmonic-devs/scale-workshop-core@a24624d

@frostburn
Copy link
Member Author

Still needs a minor tweak in the core to handle the root mode better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant