Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating non-integer EDOs #326

Closed
MaxSamo opened this issue Oct 31, 2022 · 6 comments · Fixed by #365
Closed

Creating non-integer EDOs #326

MaxSamo opened this issue Oct 31, 2022 · 6 comments · Fixed by #365
Milestone

Comments

@MaxSamo
Copy link

MaxSamo commented Oct 31, 2022

Before the last update, it was possible to create non-integer EDOs, such as 52.99683 EDO instead of 53 EDO, 18.94809 EDO instead of 19 EDO, etc.
For context, 18.94809(...) EDO is very slightly more optimal tuning than 19 EDO, according to Riemann-Zeta tuning method

@frostburn
Copy link
Member

I think of such tunings as having a stretched octave/equave.

Workarounds:

  • Create an equal temperament with the equave pre-stretched (replace 2/1 with 1202.3 etc.).
  • Use the stretch/compress modifier after creating the scale.

Feature proposal:
Disable the relative steps and absolute degrees boxes when the user tries to create non-integer EDO, but let the generation go through.

@MaxSamo
Copy link
Author

MaxSamo commented Nov 1, 2022

I will also have to clarify that it was possible to create such tunings before the last update, so it should not take a lot to re-add this feature

@frostburn
Copy link
Member

Unfortunately the whole application was re-written from scratch so implementing this incidental feature will be pushed to version 2.1.0.
Meanwhile you can use the old version if non-integer EDOs are critical to your workflow: https://sevish.com/scaleworkshop1/

@frostburn frostburn modified the milestones: First release, 2.1.0 Nov 9, 2022
@frostburn
Copy link
Member

I think it's ambiguous how many notes a non-integer EDO scale should have. Version 1 breaks when you try to divide the octave into 0.5 parts even though the step-size is well-defined.
I suggest that non-integer scales are implemented as a single step only. They should sound the same as version 1 for divisions >= 1.

@frostburn
Copy link
Member

Core functionality done... https://github.com/xenharmonic-devs/scale-workshop-core
... but let's go with the single step approach.

@MaxSamo
Copy link
Author

MaxSamo commented Nov 19, 2022

Single step approach would surely work, as long as it's not hard to set the non-integer size of an EDO. Thanks for taking time on this!

frostburn added a commit that referenced this issue Mar 26, 2023
Disable relative steps and absolute degrees inputs when divisions is not an integer.
Add css styling for disabled labels.

ref #326
frostburn added a commit that referenced this issue Nov 26, 2023
Disable relative steps and absolute degrees inputs when divisions is not an integer.

ref #326
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants