From 9c5633133eee4cd8f43e5c1947714214fb281dd5 Mon Sep 17 00:00:00 2001 From: Gabriel Buica Date: Tue, 30 Jul 2024 11:29:01 +0100 Subject: [PATCH] tracing: increase the default maximum number of spans in a trace Increases the default maximum number of spans inside a trace from `1000` to `2500`. Now that we instrumented the internal http calls, with all components enabled, the number of spans inside `xapi` component for a `vm-start` operations is slightly greater than `1000`. This causes spans to be leaked, they are removed from the ongoing span table but never added in the finished tabled. Therefore, they are lost unless the limit is change in `/etc/xapi.conf`. This should fix the issue until we implement a better abstraction for the span hashtables. Signed-off-by: Gabriel Buica --- ocaml/libs/tracing/tracing.ml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ocaml/libs/tracing/tracing.ml b/ocaml/libs/tracing/tracing.ml index 22358f7741e..3e472e29fed 100644 --- a/ocaml/libs/tracing/tracing.ml +++ b/ocaml/libs/tracing/tracing.ml @@ -313,7 +313,7 @@ module Spans = struct Hashtbl.length spans ) - let max_spans = Atomic.make 1000 + let max_spans = Atomic.make 2500 let set_max_spans x = Atomic.set max_spans x