This repository has been archived by the owner on May 1, 2024. It is now read-only.
Bug/9106 - Adding cascading fallbacks for visual state management in CheckBox #11609
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Add fallbacks in Checkbox and VisualElements that are trying to get to a "Normal" state, but may not have defined that state. Ideally this should really be up to the user to define all the states correctly, but it might be nice to have fallbacks.
Issues Resolved
API Changes
Added CommonStatesGroupName const.
Added ResetCommonStatesGroupSetters method in the Visual State Manager to revert value setters when the user is trying to return to a Normal State.
Added cascading fallbacks in the Checkbox ChangeVisualState method.
Platforms Affected
Behavioral/Visual Changes
Before/After Screenshots
Not applicable
Testing Procedure
Go to Issue9106.xaml and test different variations of defining all/some common states(Normal,Disabled,IsChecked).
The elements should always return to a state that makes sense to the user.
PR Checklist