Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Bug/9106 - Adding cascading fallbacks for visual state management in CheckBox #11609

Closed
wants to merge 4 commits into from

Conversation

mjmostachetti
Copy link
Contributor

Description of Change

Add fallbacks in Checkbox and VisualElements that are trying to get to a "Normal" state, but may not have defined that state. Ideally this should really be up to the user to define all the states correctly, but it might be nice to have fallbacks.

Issues Resolved

API Changes

Added CommonStatesGroupName const.
Added ResetCommonStatesGroupSetters method in the Visual State Manager to revert value setters when the user is trying to return to a Normal State.
Added cascading fallbacks in the Checkbox ChangeVisualState method.

Platforms Affected

  • Core/XAML (all platforms)
  • iOS
  • Android
  • UWP

Behavioral/Visual Changes

Before/After Screenshots

Not applicable

Testing Procedure

Go to Issue9106.xaml and test different variations of defining all/some common states(Normal,Disabled,IsChecked).
The elements should always return to a state that makes sense to the user.

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@samhouts samhouts self-requested a review August 3, 2020 17:38
@samhouts samhouts changed the base branch from 4.7.0 to 5.0.0 August 4, 2020 20:58
@samhouts samhouts added this to the 5.0.0 milestone Aug 4, 2020
@PureWeen PureWeen modified the milestones: 5.0.0, 5.0.1 Nov 2, 2020
@samhouts samhouts added the retarget-branch-required PR or associated issues target a milestone. Please target this PR to the matching branch. label Nov 3, 2020
@samhouts samhouts removed the retarget-branch-required PR or associated issues target a milestone. Please target this PR to the matching branch. label Nov 3, 2020
@jfversluis
Copy link
Member

Now that we're so close to the sunsetting of Xamarin.Forms unfortunately we won't be able to take this in anymore, we're really sorry about that. Nevertheless, thank you so much for your time and effort that you have put into this PR.

Please have a look at the evolution of Xamarin.Forms, .NET MAUI. A lot of development has been going on there. Hopefully this issue was already fixed in that codebase. If not, feel free to port this over to there.

Again, thank you so much for being a contributor and Xamarin.Forms user!

@jfversluis jfversluis closed this Apr 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Checked CheckBox does not update VisualState properly
5 participants