Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Allow integers as dates in phys2eventtime #14

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[WIP] Allow integers as dates in phys2eventtime #14

wants to merge 4 commits into from

Conversation

asinghvi17
Copy link
Member

@asinghvi17 asinghvi17 commented Mar 8, 2023 •
edited
Loading

This allows integer times to be used in the event.list data.frame object, by expanding the type checking constraint in phys2eventtime.

Fixes #15

TODOs:

  • Document this
  • Test it

chiraganand
chiraganand reviewed Mar 10, 2023
View reviewed changes
R/phys2eventtime.R Outdated Show resolved Hide resolved
@asinghvi17 asinghvi17 marked this pull request as ready for review March 10, 2023 09:58
@asinghvi17 asinghvi17 changed the title [WIP] Allow numeric types in phys2eventtime [WIP] Allow integers as dates in phys2eventtime Mar 11, 2023
@asinghvi17 asinghvi17 requested a review from chiraganand March 11, 2023 06:12
@Toodlepoodle Toodlepoodle mentioned this pull request Mar 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chiraganand chiraganand Awaiting requested review from chiraganand

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

eventstudies package unable to handle integer dates
2 participants
@asinghvi17 @chiraganand