Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for the main package vignette #13

Open
ajaynshah opened this issue Feb 21, 2023 · 0 comments
Open

Improvements for the main package vignette #13

ajaynshah opened this issue Feb 21, 2023 · 0 comments

Comments

@ajaynshah
Copy link
Member

  1. It would be better if the identical ylim were used for Figure 1 and Figure 2, so that the variance reduction is visually apparent.

  2. A little more work on interpreting Figure 3 would be useful. I think I see the market revving up the stock price from about -20 minutes on.

  3. We require a package that will work with all possible time frequencies (intra-day, daily, weekly, monthly, quarterly, annual, non-specific integer valued time). And, the package vignette needs to flaunt this so that it does not look like a stock market + AMM story alone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant