Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disconnects when the modified bytecode is large #2

Open
martinetlee opened this issue Jul 18, 2020 · 1 comment
Open

Disconnects when the modified bytecode is large #2

martinetlee opened this issue Jul 18, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@martinetlee
Copy link
Member

The library relies on websocket to send request to godmode-ganache-cli
There are times that this library disconnects from the ganache-cli when trying to send over a bytecode.

From experience, this issue appears when the bytecode is large. (I don't have the exact number)
I was always able to fix this by modifying the contract and making the bytecode small.

What needs to be done to resolve this issue:

  • Determine the limit of the bytecode
  • identify the root cause
  • fix if possible

This is low priority, as it doesn't limit the functionality of this library.
We can always use a contract that only contains the function that we really need to use to modify the storage.

@v-stickykeys v-stickykeys added the bug Something isn't working label Oct 18, 2020
@v-stickykeys
Copy link
Member

Yup for context I was able to increase the websocket "frame" size to mitigate this for the protocols we currently support (Compound, Maker, UniswapV2).

It would be ideal if we could use a stream but the websocket used by ganache-core doesn't supporting streaming and that's way more work than I think we want to do here.

So as discussed we will set the frame size to whatever the ethereum contract max size is and hopefully that should fix this. Issue here: xGodMode/godmode-ganache-core#3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants