Ungrib build fails when jasper version > 3.

[bakamotokatas]

/usr/bin/ld: ./ngl/libg2_4.a(dec_jpeg2000.o): in function dec_jpeg2000_': dec_jpeg2000.c:(.text+0x61): undefined reference to jpc_decode'
collect2: error: ld returned 1 exit status
make[1]: [Makefile:19: ungrib.exe] Error 1 (ignored)

/usr/bin/ld: ./ngl/libg2_4.a(dec_jpeg2000.o): in function dec_jpeg2000_': dec_jpeg2000.c:(.text+0x61): undefined reference to jpc_decode'
collect2: error: ld returned 1 exit status
make[1]: [Makefile:41: g2print.exe] Error 1 (ignored)

Also there is similar problem with NCEPLIBS;
NOAA-EMC/NCEPLIBS-g2#236

[andrewsoong]

Which compiler was used ?

[bakamotokatas]

hello @andrewsoong, I used GCC and gfortran version 12.1.1

[andrewsoong]

@bakamotokatas I am using Intel Compilers(V2018.1.48), It can compiled WPS v4.4 succussfully, but the geogrid.exe could not run.
The WPS v4.3.1 is OK.

[bakamotokatas]

@andrewsoong We're talking about other issues, I'm talking about a WPS compilation issue with the new jasper version. I can compile WPS with old jasper versions, jasper 1.900.1 or version 2 variants. There is a problem with compiling with the newly released jasper version 3. I just wrote to report a problem.

[WillTrojak]

I recently encountered this issue and the fix was to change the jpc_decode and jpc_encode functions over to jas_image_decode and jas_image_encode. It seems that the former were undocumented internal functions of Jasper which have now been removed. You have to make an additional call to jas_image_getfmt to get the fmt int.

[WillTrojak]

Is there any plan to fix this issue in a future release? The fix I made seems to work fine, I could make a PR if you like.

[weiwangncar]

@WillTrojak Does your problem also exist with --build-grib2-libs compile option? This option builds the jasper and other required grib 2 libraries at the WPS compile time.

[mgduda]

@WillTrojak If your changes work with older Jasper library versions (e.g., 1.900.X) and if they work when using the option that @weiwangncar mentioned to build an embedded copy of the Jasper library, then we'd be glad to receive a PR with your fixes. If you have any questions about the PR process, please don't hesitate to let me know and I'll be glad to help!