Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect upgrade link #950

Open
Khadreal opened this issue Dec 24, 2024 · 1 comment · May be fixed by #952
Open

Incorrect upgrade link #950

Khadreal opened this issue Dec 24, 2024 · 1 comment · May be fixed by #952
Assignees
@jeawhanlee
Labels
type: bug
Milestone
2.2.5

Comments

@Khadreal
Copy link
Contributor

Before submitting an issue please check that you’ve completed the following steps:

  • Made sure you’re on the latest version
  • Used the search feature to ensure that the bug hasn’t been reported before

Describe the bug
We need to change the infinite_3 parameter in upgrade link to infinite

To Reproduce
Steps to reproduce the behavior:

  1. On imagify upgrade banner
  2. Click on upgrade now button and select infinite
  3. The link will open in a new tab, check the link in the browser and you'll see infinite_3 as part of the url

Expected behavior
The upgrade link shouldn't contain infinite_3, it should be infinite

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
https://wp-media.slack.com/archives/C045P1RA2/p1735027976153859

Acceptance Criteria (for WP Media team use only)
Clear instructions for developers, to be added before the grooming
@piotrbak piotrbak added this to the 2.2.5 milestone Jan 9, 2025
@jeawhanlee
Copy link
Contributor

jeawhanlee commented Jan 13, 2025 •
edited
Loading

Scope a solution ✅

Update the links below to use just infinite

  • imagify-plugin/classes/Admin/AdminBar.php

    Lines 149 to 155 in 1ab429c

    if ( $this->user->is_monthly ) {
    $text .= esc_html__( 'For $11.99/month, optimize as many images as you like!', 'imagify' );
    $upgrade_link = IMAGIFY_APP_DOMAIN . '/subscription/plan_switch/?label=infinite_3&payment_plan=1&utm_source=plugin&utm_medium=notification ';
    } else {
    $text .= esc_html__( 'For $9.99/month, optimize as many images as you like!', 'imagify' );
    $upgrade_link = IMAGIFY_APP_DOMAIN . '/subscription/plan_switch/?label=infinite_3&payment_plan=2&utm_source=plugin&utm_medium=notification ';
    }

  • imagify-plugin/views/part-upsell.php

    Lines 80 to 86 in b634182

    if ( $imagify_user->is_monthly ) {
    $price = esc_html__( 'For $11.99/month only, choose unlimited image optimization!', 'imagify' );
    $upgrade_link = IMAGIFY_APP_DOMAIN . '/subscription/plan_switch/?label=infinite_3&payment_plan=1&utm_source=plugin&utm_medium=upsell_banner';
    } else {
    $price = esc_html__( 'For $9.99/month only, choose unlimited image optimization!', 'imagify' );
    $upgrade_link = IMAGIFY_APP_DOMAIN . '/subscription/plan_switch/?label=infinite_3&payment_plan=2&utm_source=plugin&utm_medium=upsell_banner';
    }

Estimate the effort ✅

[XS]

@jeawhanlee jeawhanlee self-assigned this Jan 14, 2025
@jeawhanlee jeawhanlee linked a pull request Jan 14, 2025 that will close this issue
Open
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeawhanlee jeawhanlee

Labels
type: bug
Projects
None yet
Milestone
2.2.5
Development

Successfully merging a pull request may close this issue.

Closes #950: Incorrect upgrade link wp-media/imagify-plugin
3 participants
@Khadreal @piotrbak @jeawhanlee