Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the country/region classes, deprecated calls functions and parameters need to be removed in the future #1016

Open
JeffPyeBrook opened this issue Mar 31, 2014 · 7 comments
Milestone

Comments

@JeffPyeBrook
Copy link
Contributor

As of release 3.,8.14, there are a couple of places in the class methods where special code is in place to gracefully handle backwards compatibility.

Because of where the changes are in the class construction it is not practical to use the wpsc-deprecated file. The code does give a deprecated warning, and will eit in a manner similar to an undefined function if deprecated processing is not enabled. That should make it easy enough for third-party developers to find.

The special code has been conspicuously commented and refers back to this specific issue so that some reasonable amount of time/releases into the future we can remove the special purpose backwards compatibility code.

@JeffPyeBrook JeffPyeBrook added this to the 3.9.5 milestone Mar 31, 2014
@JustinSainton JustinSainton modified the milestones: 4.0, 3.9.5 Nov 10, 2014
@JustinSainton
Copy link
Member

@JeffPyeBrook Do you imagine you'll have time to address anything here specifically for the 4.0 release? Happy to punt to a future release if you are.

@JeffPyeBrook
Copy link
Contributor Author

@JustinSainton I beleive the countries class PR that is queued up should handle much of what is needed here.

@JustinSainton
Copy link
Member

@JeffPyeBrook Awesome. Do you see that being ready soon?

@JeffPyeBrook
Copy link
Contributor Author

i have been testing it and haven't seen any issues yet, not sure anyone has looked at it?

@JustinSainton
Copy link
Member

I've looked at it, haven't used it yet though. There were some todos here that seem unfinished?

@JustinSainton
Copy link
Member

@JeffPyeBrook alright, just gave it a final audit. seems to be pretty close.

@JustinSainton
Copy link
Member

@JeffPyeBrook I'm going to go ahead and punt to 4.1. Now that we're in beta, it's a bit too late to merge. If you can take a look at the todos, we can merge it early in 4.1. Otherwise, I'll take a stab at it then.

@JustinSainton JustinSainton modified the milestones: 4.1, 4.0 Jul 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants