Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug timings are potentially confusing #22

Open
timkurvers opened this issue Aug 13, 2018 · 1 comment
Open

Debug timings are potentially confusing #22

timkurvers opened this issue Aug 13, 2018 · 1 comment
Labels
bug Something isn't working enhancement New feature or request

Comments

@timkurvers
Copy link
Member

timkurvers commented Aug 13, 2018

Spelunker uses debug for logging debug messages during operation.

One of its features, millisecond diffing, is potentially confusing:

When actively developing an application it can be useful to see when the time spent between one debug() call and the next. Suppose for example you invoke debug() before requesting a resource, and after as well, the "+NNNms" will show you how much time was spent between calls.

Given that Spelunker uses separate namespaces for timed operations – such as caching, DBC and database queries – these diffs may be interpret as query timers, which couldn't be further from the truth depending on the order of operations.

screen shot 2018-08-13 at 21 43 16

@timkurvers timkurvers added bug Something isn't working enhancement New feature or request labels Aug 13, 2018
@timkurvers
Copy link
Member Author

timkurvers commented Aug 13, 2018

The easy solution here would be to log both before and after an operation as suggested by the debug docs. This may cause issues due to the asynchronous nature of GraphQL resolvers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant