Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics window, game window #110

Open
DanielBruegmann opened this issue Jun 22, 2013 · 3 comments
Open

statistics window, game window #110

DanielBruegmann opened this issue Jun 22, 2013 · 3 comments

Comments

@DanielBruegmann
Copy link
Contributor

The statistics window should not cover part of the game view. The game window should have the focus so escape closes the terminates, without having to click in the game view first. It might be easier to make sure that the game view is always on top and not worry about the overlap for now. Maybe should be only one window at some point in the future. Would it be possible to show the statistics in the fullscreen mode and do we want this?

@DanielBruegmann
Copy link
Contributor Author

This commit solves the problem with keyboard input for me (the game window has the focus) and causes the game window to be on top. Moving to Optional.

@PascalCremer
Copy link
Contributor

We should do some refactoring here. Now there is no reason why StatisticsView should implement runnable. But lets discuss it first. Is there some reason why we would like the windows to run in a thread? One could think of buggy AIs which have endless loops causing Keyboard input not to be processed anymore. But since we want to run the AIs in parallel as a long term goal, the graphics can run in the main loop.

@PascalCremer
Copy link
Contributor

One can also consider putting both frames in one window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants