Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the message of waitForUrlToBeEqualToExpectedUrl and related methods #122

Open
wlsf82 opened this issue Jan 17, 2021 · 0 comments
Open

Comments

@wlsf82
Copy link
Owner

wlsf82 commented Jan 17, 2021

Currently, the message of the waitForUrlToBeEqualToExpectedUrl method is something like:

Failed: current URL is different than expected URL: 'https://my-app.com'.

This lets us know that the URL is different than the expected one, but it does not tell us what's the current URL, which could be a piece of very helpful information when debugging failures.

I suggest that we change the message to something like:

Failed: current URL (https://www.i-am-the-current-url.com) is different than expected URL (https://im-another-url.com).

Note: remember to do the same for related methods (i.e., waitForUrlNotToBeEqualToExpectedUrl, waitForUrlToContainString, waitForUrlNotToContainString.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant